search

Shopify / theme-check

The Ultimate Shopify Theme Linter
Other
338 stars 95 forks source link

[Intelligent code completion] `AssignmentsFinder` doesn't not index literal types #673

Closed karreiro closed 1 year ago

karreiro commented 1 year ago

The AssignmentsFinder is not indexing literal types:

{%- assign text1 = 'Some potions create whitespace.' -%}
{{ text1.█

In the snippet above, text1 is not indexed by the AssignmentsFinder. The language server currently doesn't suggest anything in the scenario above, still the AssignmentsFinder must index that variable.

karreiro commented 1 year ago

Fixed by https://github.com/Shopify/theme-check/pull/669 (d7144ade1016a7eda218dd636960e6e34ba9288e)