{{ '<p>Text to be escaped.</p>' | ⬜️ }} → Verify that escape, escape_once, url_escape, url_param_escape are suggested (among all other string filters).
{{ page_description | ⬜️ }} → Verify that escape, escape_once, url_escape, url_param_escape are not suggested (among all other string filters).
WHY are these changes introduced?
WHAT is this pull request doing?
Reads
denied_filters
from potentially already escaped object in SourceIndex, to reject these filters from suggestions.How to test your changes?
:warning: Before testing, please note: Your
objects.json
used by SourceIndex needs to be in sync with theobjects.json
in https://github.com/Shopify/storefront-renderer/pull/16486!{{ '<p>Text to be escaped.</p>' | ⬜️ }}
→ Verify thatescape
,escape_once
,url_escape
,url_param_escape
are suggested (among all other string filters).{{ page_description | ⬜️ }}
→ Verify thatescape
,escape_once
,url_escape
,url_param_escape
are not suggested (among all other string filters).