Shopify / theme-check

The Ultimate Shopify Theme Linter
Other
340 stars 96 forks source link

[Intelligent code completion] Do not suggest escape filters for objects which are already escaped #692

Closed Poitrin closed 1 year ago

Poitrin commented 1 year ago

WHY are these changes introduced?

WHAT is this pull request doing?

Reads denied_filters from potentially already escaped object in SourceIndex, to reject these filters from suggestions.

How to test your changes?

:warning: Before testing, please note: Your objects.json used by SourceIndex needs to be in sync with the objects.json in https://github.com/Shopify/storefront-renderer/pull/16486!