search

Shopify / theme-check

The Ultimate Shopify Theme Linter
Other
338 stars 95 forks source link

Add support for the new item_count_for_variant filter #697

Closed bakura10 closed 1 year ago

bakura10 commented 1 year ago

Shopify added silently a new, very useful filter that allows to know how many items has been added for a given variant, independently of the multiple line items (documentation here: https://shopify.dev/api/liquid/filters/item_count_for_variant)

Theme check unfortunately does not support it and raise an error.

charlespwd commented 1 year ago

Seems like we do: https://github.com/Shopify/theme-liquid-docs/blob/main/data/filters.json#L2-L32

We have them sync'ed now. Running latest release?

bakura10 commented 1 year ago

Maybe not actually. I am using Shopify CLI, it seems they have not yet updated the deps :)

karreiro commented 1 year ago

@bakura10 Shopify CLI has been updated with the latest Theme Check version.

I've double-checked and it working fine now: demo1

Still, please, let us know if I missed something ^