Shopify / theme-check

The Ultimate Shopify Theme Linter
Other
340 stars 96 forks source link

Add shopify-dev link to suggestion title #700

Closed mgmanzella closed 1 year ago

mgmanzella commented 1 year ago

Closes https://github.com/Shopify/theme-check/issues/699

Summary

Tophatting

Open a theme and test the following scenarios. Type the following and at the cursor type Ctrl-Space. When a suggestion appears, click the title link. Confirm the link is a sensible suggestion for what you typed. Object properties can be deep linked but tag parameters cannot

Object

{{ address█ }}

Object property

{{ address.cit█ }}

Tag

{% if█ %}

Filter

{{ cart | external_video_tag█ }}

Filter parameter

TODO -- I can't seem to find an example for this case where we suggest a filter parameter?