search

Shopify / theme-check

The Ultimate Shopify Theme Linter
Other
333 stars 96 forks source link

Add a new VariableName check #717

Open Darhazer opened 1 year ago

Darhazer commented 1 year ago

Following https://github.com/Shopify/theme-check/issues/64 this check requires that variable names use snake_case

This is my first theme check so any feedback is welcome. As a learning exercise, I intend to do ~all~ most of the checks suggested in #64 so if anything there is outdated, I'd appreciate updating.

tmmgrafikr commented 6 months ago

@Darhazer This PR dead? 😢

Darhazer commented 6 months ago

@tmmgrafikr seems to me theme-check is not really maintained.

tmmgrafikr commented 6 months ago

@tmmgrafikr seems to me theme-check is not really maintained.

Do you use this custom check yourself?

Darhazer commented 6 months ago

I'm not using theme-check at the moment. I was just interested in the project from the perspective of being a linter for liquid templates

tmmgrafikr commented 1 month ago

Created an update PR of this here: https://github.com/Shopify/theme-tools/pull/359