Fix an issue where the error message 'UndefinedObject: Undefined object section' is being incorrectly reported - Githubissues

Shopify / theme-check

The Ultimate Shopify Theme Linter

Other

338 stars 95 forks source link

Fix an issue where the error message 'UndefinedObject: Undefined object section' is being incorrectly reported #732

Closed karreiro closed 1 year ago

karreiro commented 1 year ago

What are you trying to accomplish?

During my review and testing of the https://github.com/Shopify/theme-liquid-docs/pull/190 PR, I noticed that Theme Check was inaccurately flagging the error: UndefinedObject: Undefined object 'section' offense. This issue was caused by a minor change made in https://github.com/Shopify/theme-check/pull/725.

To resolve this problem, I changed the SourceIndex to no longer ignore all theme_app_extension_labels.

As https://github.com/Shopify/theme-check/pull/725 has not been released, I'm not introducing a changelog for this.

How to test your changes?

Run ./bin/theme-check <theme_path>
Notice that incorrect error: UndefinedObject: Undefined object 'section' errors are no longer reported