Closed jenshenny closed 7 months ago
The CI failures look unrelated to the changes (CI fails on main at the moment https://github.com/Shopify/theme-check/actions/runs/8904032322/job/24453139188). @karreiro @mgmanzella would you or your team be able to push this along?
Ah gotcha! Thanks for letting me know @karreiro - I'll close this off :)
What are you trying to accomplish?
The
.ruby-version
file is the ecosystem standard for defining a Ruby version. This PR adds the.ruby-version
file, ensures arequired_ruby_version
is set, and removes all other references to Ruby in this repository, aligning it with the standard.What should reviewers focus on?
Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant:
.ruby-version
file is present with the correct Ruby version definedrequired_ruby_version
in your gemspec is setdev.yml
Ruby task (before:- ruby: x.x.x
, after:- ruby
)Gemfile
(no lines withruby <some-version>
)Gemfile.lock
is built with the defined Ruby versionTargetRubyVersion
defined inrubocop.yml
(reads fromrequired_ruby_version
on Rubocop 1.61.0)ruby/setup-ruby
Github Actions that do not run on a Ruby matrix (no lines withruby-version: “x.x”
)To establish consistency, the
required_ruby_version
is set to 2.7. If you think that another version is a better fit, please make the applicable changes.Please ensure passing CI and merge this PR if it looks good, this PR will be addressed if there isn't any activity after 4 weeks.