Shopify / theme-check

The Ultimate Shopify Theme Linter
Other
340 stars 96 forks source link

Centralize Ruby Version to `.ruby-version` #758

Closed jenshenny closed 7 months ago

jenshenny commented 8 months ago

What are you trying to accomplish?

The .ruby-version file is the ecosystem standard for defining a Ruby version. This PR adds the .ruby-version file, ensures a required_ruby_version is set, and removes all other references to Ruby in this repository, aligning it with the standard.

What should reviewers focus on?

[!IMPORTANT] Please verify the following before merging:

Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant:

To establish consistency, the required_ruby_versionis set to 2.7. If you think that another version is a better fit, please make the applicable changes.

Please ensure passing CI and merge this PR if it looks good, this PR will be addressed if there isn't any activity after 4 weeks.

jenshenny commented 7 months ago

The CI failures look unrelated to the changes (CI fails on main at the moment https://github.com/Shopify/theme-check/actions/runs/8904032322/job/24453139188). @karreiro @mgmanzella would you or your team be able to push this along?

jenshenny commented 7 months ago

Ah gotcha! Thanks for letting me know @karreiro - I'll close this off :)