Shopify / theme-extension-getting-started

A theme app extension boilerplate that highlights the basic structure and features that are available to developers who want to integrate their apps with Shopify Online Stores.
https://shopify.dev/apps/online-store/theme-app-extensions/getting-started
MIT License
105 stars 45 forks source link

how do i add jquery in theme app extension #4

Closed deve1212 closed 7 months ago

deve1212 commented 3 years ago

importing jquery in liquid file like this ,have copied the min js jquery in assets with filename-jquery.min.js- doing this raise following error in console ,while i do shopify extension push -

✗ JavaScript on every page load exceeds compressed size threshold (10000 Bytes), consider using the import on interaction pattern. at blocks/review_carousel.liquid

is there a way anyone knows on how to add jquery, i need it for carousel

JoshHighland commented 3 years ago

Can you load it externally from a CDN? Im guessing there is no need to ship the file.

tommy921092 commented 2 years ago

https://github.com/Shopify/theme-check/blob/main/docs/checks/remote_asset.md

I don't know why they don't explain their codes in example