search

Shopify / theme-extension-getting-started

A theme app extension boilerplate that highlights the basic structure and features that are available to developers who want to integrate their apps with Shopify Online Stores.
https://shopify.dev/apps/online-store/theme-app-extensions/getting-started
MIT License
105 stars 45 forks source link

Update app block example to use the latest image_url filter #8

Closed mmorissette closed 2 years ago

mmorissette commented 2 years ago

The example PR contained numerous theme-check errors. The updates here address all of them

➜  theme-app-extension shopify extension check
Checking . ...
blocks/app-block.liquid:13: style: SpaceInsideBraces: Space missing after '{{'.
    <img src="{{ block.settings.image_1 | img_url: '1024x' }}" alt="{{ block.settings.image_1.alt }}" loading="lazy" widt...
                 ^

blocks/app-block.liquid:13: style: SpaceInsideBraces: Space missing before '}}'.
    <img src="{{ block.settings.image_1 | img_url: '1024x' }}" alt="{{ block.settings.image_1.alt }}" loading="lazy" widt...

blocks/app-block.liquid:13: style: SpaceInsideBraces: Space missing after '{{'.
    <img src="{{ block.settings.image_1 | img_url: '1024x' }}" alt="{{ block.settings.image_1.alt }}" loading="lazy" widt...
                 ^

blocks/app-block.liquid:13: style: SpaceInsideBraces: Space missing before '}}'.
    <img src="{{ block.settings.image_1 | img_url: '1024x' }}" alt="{{ block.settings.image_1.alt }}" loading="lazy" widt...
                         ^

blocks/app-block.liquid:20: style: SpaceInsideBraces: Space missing after '{{'.
    <img src="{{ block.settings.image_2 | img_url: '1024x' }}" alt="{{ block.settings.image_2.alt }}" loading="lazy" widt...
                 ^

blocks/app-block.liquid:20: style: SpaceInsideBraces: Space missing before '}}'.
    <img src="{{ block.settings.image_2 | img_url: '1024x' }}" alt="{{ block.settings.image_2.alt }}" loading="lazy" widt...

blocks/app-block.liquid:20: style: SpaceInsideBraces: Space missing after '{{'.
    <img src="{{ block.settings.image_2 | img_url: '1024x' }}" alt="{{ block.settings.image_2.alt }}" loading="lazy" widt...
                 ^

blocks/app-block.liquid:20: style: SpaceInsideBraces: Space missing before '}}'.
    <img src="{{ block.settings.image_2 | img_url: '1024x' }}" alt="{{ block.settings.image_2.alt }}" loading="lazy" widt...
                         ^

blocks/app-block.liquid:27: style: SpaceInsideBraces: Space missing before '}}'.
    <img src="{{ block.settings.image_3 | img_url: '1024x'}}" alt="{{ block.settings.image_3.alt }}" loading="lazy" width...
                                                   ^

blocks/app-block.liquid:27: style: SpaceInsideBraces: Space missing after '{{'.
    <img src="{{ block.settings.image_3 | img_url: '1024x'}}" alt="{{ block.settings.image_3.alt }}" loading="lazy" width...
                 ^

blocks/app-block.liquid:27: style: SpaceInsideBraces: Space missing before '}}'.
    <img src="{{ block.settings.image_3 | img_url: '1024x'}}" alt="{{ block.settings.image_3.alt }}" loading="lazy" width...
                                                                                                                        ^

blocks/app-block.liquid:27: style: SpaceInsideBraces: Space missing after '{{'.
    <img src="{{ block.settings.image_3 | img_url: '1024x'}}" alt="{{ block.settings.image_3.alt }}" loading="lazy" width...
                 ^

blocks/app-block.liquid:27: style: SpaceInsideBraces: Space missing before '}}'.
    <img src="{{ block.settings.image_3 | img_url: '1024x'}}" alt="{{ block.settings.image_3.alt }}" loading="lazy" width...
                         ^

blocks/app-block.liquid:34: style: SpaceInsideBraces: Space missing after '{{'.
    <img src="{{ block.settings.image_4 | img_url: '1024x' }}" alt="{{ block.settings.image_4.alt }}" loading="lazy" widt...
                 ^

blocks/app-block.liquid:34: style: SpaceInsideBraces: Space missing before '}}'.
    <img src="{{ block.settings.image_4 | img_url: '1024x' }}" alt="{{ block.settings.image_4.alt }}" loading="lazy" widt...

blocks/app-block.liquid:34: style: SpaceInsideBraces: Space missing after '{{'.
    <img src="{{ block.settings.image_4 | img_url: '1024x' }}" alt="{{ block.settings.image_4.alt }}" loading="lazy" widt...
                 ^

blocks/app-block.liquid:34: style: SpaceInsideBraces: Space missing before '}}'.
    <img src="{{ block.settings.image_4 | img_url: '1024x' }}" alt="{{ block.settings.image_4.alt }}" loading="lazy" widt...
                         ^

blocks/app-block.liquid:13: suggestion: DeprecatedFilter: Deprecated filter `img_url`, consider using `image_url`.
    <img src="{{ block.settings.image_1 | img_url: '1024x' }}" alt="{{ block.settings.image_1.alt }}" loading="lazy" widt...
                                          ^^^^^^^^^^^^^^^^^

blocks/app-block.liquid:20: suggestion: DeprecatedFilter: Deprecated filter `img_url`, consider using `image_url`.
    <img src="{{ block.settings.image_2 | img_url: '1024x' }}" alt="{{ block.settings.image_2.alt }}" loading="lazy" widt...
                                          ^^^^^^^^^^^^^^^^^

blocks/app-block.liquid:27: suggestion: DeprecatedFilter: Deprecated filter `img_url`, consider using `image_url`.
    <img src="{{ block.settings.image_3 | img_url: '1024x'}}" alt="{{ block.settings.image_3.alt }}" loading="lazy" width...
                                          ^^^^^^^^^^^^^^^^

blocks/app-block.liquid:34: suggestion: DeprecatedFilter: Deprecated filter `img_url`, consider using `image_url`.
    <img src="{{ block.settings.image_4 | img_url: '1024x' }}" alt="{{ block.settings.image_4.alt }}" loading="lazy" widt...
                                          ^^^^^^^^^^^^^^^^^

11 files inspected, 21 offenses detected, 21 offenses auto-correctable
➜  theme-app-extension