Get rid of AJV, long live vscode-json-languageservice. - Githubissues

Shopify / theme-tools

Everything developer experience for Shopify themes

https://shopify.dev/docs/themes

MIT License

71 stars 19 forks source link

Get rid of AJV, long live vscode-json-languageservice. #331

Closed charlespwd closed 6 months ago

charlespwd commented 6 months ago

What are you adding in this PR?

This is a big refactor.

Removes ajv dependency (replaced by vscode-json-languageservice)
Breaking: Removes theme-docs compile-schema
Breaking: Redesigns the jsonValidationSet public API
Adds "bring-your-own-json-schema" support
Adds "$ref" support to schemas for code reuse :D
Adds ValidJSON check

Fixes Shopify/develop-advanced-edits#145

Before you deploy

[x] This PR includes a new checks or changes the configuration of a check
- [x] I included a minor bump changeset
- [x] It's in the allChecks array in src/checks/index.ts
- [x] I ran yarn update-configs and committed the updated configuration files

[x] I included a minor bump changeset
[ ] My feature is backward compatible: Yes and no (but it's documented!) It isn't for the browser-dependencies.