search

Shopify / theme-tools

Everything developer experience for Shopify themes
https://shopify.dev/docs/themes
MIT License
48 stars 14 forks source link

Prevent loading the same third party check more than once #341

Closed davidwarrington closed 3 months ago

davidwarrington commented 3 months ago

What are you adding in this PR?

Registering plugins via a Set to prevent accidentally loading the same plugin more than once, which in turn prevents auto fixes from running.

Fixes #336

What did you learn?

Not exciting for anyone else, but I learned how the Theme Check config is resolved and loaded.

Before you deploy

davidwarrington commented 3 months ago

I have signed the CLA!

charlespwd commented 3 months ago

Ran the tests locally. Should be good! TY for contribution :)