Adds new check for uniqueness of ids for blocks - Githubissues

Shopify / theme-tools

Everything developer experience for Shopify themes

https://shopify.dev/docs/themes

MIT License

48 stars 14 forks source link

Adds new check for uniqueness of ids for blocks #363

Closed MateusJabour closed 1 month ago

MateusJabour commented 1 month ago

What are you adding in this PR?

Add a new theme check called UniqueStaticBlockId, which ensures the uniqueness of the ids of static blocks defined in a block or section.

Read more here: https://docs.google.com/document/d/1d1EpwfhbgSubLjEqMePZ30ZWJovuCt2mJQslgWSwex0/edit#heading=h.p7g70mn8jka8

Before you deploy

[x] This PR includes a new checks or changes the configuration of a check
- [ ] I included a minor bump changeset
- [ ] It's in the allChecks array in src/checks/index.ts
- [ ] I ran yarn build and committed the updated configuration files
- [ ] If applicable, I've updated the theme-app-extension.yml config

[ ] I included a minor bump changeset
[ ] My feature is backward compatible

[ ] I included a patch bump changeset

albchu commented 1 month ago

Oh also please include a changelog for this addition. Ex: "Add UniqueStaticBlockId check to ensure the uniqueness of the ids of static blocks defined in a block or section."