Shopify / theme-tools

Everything developer experience for Shopify themes
https://shopify.dev/docs/themes
MIT License
80 stars 24 forks source link

Support `content_for ""` first argument completion #569

Closed charlespwd closed 1 week ago

charlespwd commented 2 weeks ago

We want "block" or "blocks" completion in the LiquidString node.

{% content_for "â–ˆ"%}
{% content_for "bâ–ˆ" %}

Steps:

Smintfy commented 2 weeks ago

Hello, @charlespwd

I added "block" and "blocks" completion inside the content_for tag. I hope the attached video is the desired feature or output. Hope you can check it out :)

I had to use the branch feature/content_for_tag to be able to use the NodeTypes.ContentForMarkup because I couldn't find it on the main branch 😅

https://github.com/user-attachments/assets/9f5aec3d-f6ed-467b-906e-c35f73856bc8

charlespwd commented 2 weeks ago

That's exactly what we want :o

Also, #568 is merged on main if you want to make a PR :) :pray:

charlespwd commented 1 week ago

Fixed by #577 and #582. Thank you @Smintfy :pray: