search

Shopify / theme-tools

Everything developer experience for Shopify themes
https://shopify.dev/docs/themes
MIT License
76 stars 23 forks source link

VS Shopify Liquid Extension > "Request textDocument/hover failed" #576

Open ceri-waterscreative opened 7 hours ago

ceri-waterscreative commented 7 hours ago

While hovering of unsaved JSON files an error is produced: "Request textDocument/hover failed" Image

Latest verison of the CLI & Extension Windows 11

See video here: https://streamable.com/6l9wqq

charlespwd commented 5 hours ago

To whoever fixes this:

Looks like we're being too permissive in here and here since we removed the scheme to give room for remote URIs.

Given we check JSON files, we should make sure they are theme JSON files before forwarding the requests to the JSON language service.