Closed navdeep5 closed 1 week ago
Resolves https://github.com/Shopify/theme-tools/issues/552
This PR introduces enhanced validation checks for local and static blocks, combining the following functionalities:
Validate that theme blocks do not utilize locally scoped blocks.
Ensure that sections using local blocks will not use theme blocks.
Validate that static blocks do not have a "name" property.
"name"
With this being a new check, we will want to update https://github.com/Shopify/shopify-dev so users can understand their errors. Developer Docs changes: https://github.com/Shopify/shopify-dev/pull/50568
While writing this check, I learned about static blocks -- how they are represented in liquid and their associated do's and don'ts.
changeset
allChecks
src/checks/index.ts
yarn build
theme-app-extension.yml
What are you adding in this PR?
Resolves https://github.com/Shopify/theme-tools/issues/552
This PR introduces enhanced validation checks for local and static blocks, combining the following functionalities:
Validate that theme blocks do not utilize locally scoped blocks.
Ensure that sections using local blocks will not use theme blocks.
Ensure that sections using local blocks will not use theme blocks.
Validate that static blocks do not have a
"name"
property.What's next? Any followup issues?
With this being a new check, we will want to update https://github.com/Shopify/shopify-dev so users can understand their errors. Developer Docs changes: https://github.com/Shopify/shopify-dev/pull/50568
What did you learn?
While writing this check, I learned about static blocks -- how they are represented in liquid and their associated do's and don'ts.
Before you deploy
changeset
allChecks
array insrc/checks/index.ts
yarn build
and committed the updated configuration filestheme-app-extension.yml
configchangeset
changeset