Fetch metafield definitions on start-up

Shopify / theme-tools

Everything developer experience for Shopify themes

https://shopify.dev/docs/themes

MIT License

80 stars 24 forks source link

Fetch metafield definitions on start-up #597

Open aswamy opened 1 week ago

aswamy commented 1 week ago

What are you adding in this PR?

Part of https://github.com/Shopify/theme-tools/issues/502

Adding the ability to fetch metafield definitions on VSCode startup
Does not check the version of the CLI
Timeouts if the CLI does not complete the action

What's next? Any followup issues?

Should we be adding .shopify/metafields.json as part of gitignore for themes?

Before you deploy

[x] I included a minor bump changeset

aswamy commented 5 days ago

@charlespwd Should we also only do this if we're working with themes, and not theme app extensions?

charlespwd commented 16 hours ago

Should we also only do this if we're working with themes, and not theme app extensions?

I think so. At least until we validate we have a solution for them. Can they even use metafields? Probably?

We do have a getModeForURI: Promise<'theme' | 'app'> in the language server, but it depends on how we load the config. Probably going to be fun (not) to use that from the outside. 😓