Shopify / theme-tools

Everything developer experience for Shopify themes
https://shopify.dev/docs/themes
MIT License
80 stars 24 forks source link

Added missing schema check for theme app extension #613

Closed AribaRajput closed 5 hours ago

AribaRajput commented 2 days ago

What are you adding in this PR?

cc (collab): @itsjustriley

Closes https://github.com/Shopify/theme-tools/issues/402.

Shopify dev docs PR: https://github.com/Shopify/shopify-dev/pull/50817

Adds a theme check on theme app extensions for missing schema.

What's next? Any followup issues?

No followup issues.

What did you learn?

Cannot pass context into codePathStart() or codePathEnd(). Theme app extensions cannot currently be tophatted in Horizon.

Before you deploy

AribaRajput commented 5 hours ago

/shipit