Added in theme check for all unused translations - Githubissues

Shopify / theme-tools

Everything developer experience for Shopify themes

https://shopify.dev/docs/themes

MIT License

80 stars 24 forks source link

Added in theme check for all unused translations #616

Closed AribaRajput closed 3 hours ago

AribaRajput commented 22 hours ago

What are you adding in this PR?

What's next? Any followup issues?

What did you learn?

Before you deploy

[ ] This PR includes a new checks or changes the configuration of a check
- [ ] I included a minor bump changeset
- [ ] It's in the allChecks array in src/checks/index.ts
- [ ] I ran yarn build and committed the updated configuration files
- [ ] If applicable, I've updated the theme-app-extension.yml config

[ ] I included a minor bump changeset
[ ] My feature is backward compatible

[ ] I included a patch bump changeset

AribaRajput commented 3 hours ago

This will need some prereqs (Injecting DocumentManager into theme-tools being the first step. Needs further support.) This check was a LiquidCheck and not a JSONCheck so it needs to be rewritten next week on a fresh branch once the prereqs are done