Custom checkout options are getting reset after a deployment

Shopify / themekit

Shopify theme development command line tool.

https://shopify.dev/tools/theme-kit

MIT License

1.19k stars 374 forks source link

Custom checkout options are getting reset after a deployment #876

Closed lamalamaMark closed 3 years ago

lamalamaMark commented 3 years ago

Describe the bug Custom checkout options are getting reset after a deployment. For example, a custom logo and custom accent colors is set back to the default options.

To Reproduce Steps to reproduce the behavior:

Customize the checkout via Settings > Checkout in the Shopify admin
run command 'theme deploy --env=production --allow-live
Checkout custom checkout settings and see they are all set back to default

Expected behavior We expect that custom settings are kept in tact.

Environment

OS , macOS Catalina
Themekit version 1.1.4
- Editor Sublime
- ignore_files:
- node_modules/
- parts/
- components/
- base/

andyw8 commented 3 years ago

Hi @lamalamaMark

This is likely because some entries in your local config in config/settings_data.json are overwriting settings made in Admin. There are two ways around this:

You can choose to add this file to the ignore_files in the Theme Kit config.yml.
You can download the settings before deploying with theme download config/settings_data.json.

lamalamaMark commented 3 years ago

Awesome, definitely was causing the situation.

andyw8 commented 3 years ago

Ok, good to hear. I've opened #877 to see if we can make this clearer.