Shopify / themekit

Shopify theme development command line tool.
https://shopify.dev/tools/theme-kit
MIT License
1.19k stars 374 forks source link

Recursively deleted all snippet files unprompted. #912

Open johnfuel opened 3 years ago

johnfuel commented 3 years ago

Describe the bug Renamed a file in the snippet folder while themekit was watching and caused themekit to recursively delete all files in snippets folder. Local files remain untouched while theme files are removed from Shopify.

[0] 12:31:38 [development] processing snippets/social-sharing.liquid [0] 12:31:38 [development] Deleted snippets/social-sharing.liquid [0] 12:31:38 [development] processing templates/collection.custom.liquid [0] 12:31:38 [development] Deleted templates/collection.custom.liquid [0] 12:31:38 [development] processing snippets/purgecss-whitelist.liquid [0] 12:31:39 [development] Deleted snippets/purgecss-whitelist.liquid [0] 12:31:39 [development] processing snippets/section-heading-eyebrow.liquid [0] 12:31:39 [development] Deleted snippets/section-heading-eyebrow.liquid [0] 12:31:39 [development] processing snippets/vendor-klaviyo-back-in-stock.liquid [0] 12:31:39 [development] Deleted snippets/vendor-klaviyo-back-in-stock.liquid [0] 12:31:39 [development] processing templates/404.liquid [0] 12:31:40 [development] Deleted templates/404.liquid [0] 12:31:40 [development] processing templates/list-collections.liquid [0] 12:31:40 [development] Deleted templates/list-collections.liquid [0] 12:31:40 [development] processing snippets/scripts-rosewood-support.liquid [0] 12:31:40 [development] Deleted snippets/scripts-rosewood-support.liquid [0] 12:31:40 [development] processing snippets/search-form.liquid [0] 12:31:41 [development] Deleted snippets/search-form.liquid etc...

To Reproduce Steps to reproduce the behavior:

  1. run command 'theme watch'
  2. rename file in snippet folder, in this case a file "icon-filter.svg" was renamed "svg-icon-filter.liquid"

Expected behavior Themekit should have deleted the snippet file "icon-filter.svg" and deployed "svg-icon-filter.liquid"

Environment (please complete the following information):

Additional context running command 'theme deploy' does not remedy the damage. It seems themekit doesn't realize those files were delete so doesn't deploy them back.

tanema commented 3 years ago

This seems like a duplicate of https://github.com/Shopify/themekit/issues/893

Can you update to 1.1.6 and see if that helps?