search

Shopify / themekit

Shopify theme development command line tool.
https://shopify.dev/tools/theme-kit
MIT License
1.19k stars 374 forks source link

theme open command produces a url with to https:// breaking the link. #915

Closed mcqua007 closed 3 years ago

mcqua007 commented 3 years ago

Describe the bug The bug occurs while running command theme open, this command should open a preview theme url but produces a broken links due to two https. Example response: [development] opening https://https://EXAMPLE.myshopify.com?preview_theme_id=118754574489

*Note Just removing the extra https makes the link work as it should To Reproduce Steps to reproduce the behavior:

  1. run command 'theme open`
  2. open produce url It's broken
  3. theres two https:// as shown above

Expected behavior That the link produce not be broken and have on https

Environment (please complete the following information):

tanema commented 3 years ago

Do you have https://EXAMPLE.myshopify.com as your store in your config? If so remove the protocol from your config

mcqua007 commented 3 years ago

@tanema Oh my...I feel like such a fool. I recently copied this theme from another and setup the config super quick. I did have the protocol in the config. Thanks for the help.