Shopify / themekit

Shopify theme development command line tool.
https://shopify.dev/tools/theme-kit
MIT License
1.2k stars 375 forks source link

Theme download cannot download live settings_data.json #919

Open artyrcheek opened 3 years ago

artyrcheek commented 3 years ago

when i run theme download config/settings_data.json --live --no-ignore -v on a theme with an outdated settings_data.json file it returns:

[development] Skipped config/settings_data.json (Checksum: 09f9535a9b6a64892140d5fb41a6447a)
[development] 1 files, No Change: 1

Implying that the settings_data.json files are the same, when they are not

To Reproduce Steps to reproduce the behavior:

  1. run command 'theme download config/settings_data.json --live --no-ignore -v' on theme_id which has an outdated settings_data.json file

Expected behavior settings_data.json would download from live theme, this would be really useful in theme development to quickly have section settings match that of live site, rather than having to do it manually

Environment (please complete the following information):

hpawe01 commented 3 years ago

I cannot reproduce it with the following commands:

Every time my outdated settings_data.json is overwritten with the latest version from Shopify.

Environment:

So there is probably an issue with the macOS version of ThemeKit. Maybe someone with a mac can verify.