Shopify / themekit

Shopify theme development command line tool.
https://shopify.dev/tools/theme-kit
MIT License
1.2k stars 375 forks source link

Themekit has issues with downloading/removing compiled liquid assets #959

Open ahurlburt opened 3 years ago

ahurlburt commented 3 years ago

New version of themekit has strange/undesirable behaviour when dealing with compiled liquid assets (like js.liquid / scss.liquid)

This issue affects workflows where the latest theme files are downloaded (using theme download)

Pre-requisites:

Liquid file in assets folder (ie theme.scss.liquid) which was previously deployed

To Reproduce:

1 - download latest theme files using theme download) 2 - list files and you will see you now have assets/theme.scss.liquid and assets/theme.scss 3 - attempt to push updates to some files in theme theme deploy

You will now get the following warning:

image

Ok this seems annoying but should be solvable by deleting the non-liquid version, which should then be re-compiled (as per the warning message)

4 - rm assets/theme.scss 5 - theme deploy

Now this error occurs:

image

I'm assuming this is a bug or is there a workflow that works around this? This never used to happen with previous versions of themekit...

jonasbrenig commented 3 years ago

having the same issue