Shopify / themekit

Shopify theme development command line tool.
https://shopify.dev/tools/theme-kit
MIT License
1.17k stars 369 forks source link

Error in config if there's double indentation #966

Open Curzey opened 2 years ago

Curzey commented 2 years ago

Describe the bug config.yml does not respect ignore_files settings if the respective file or path starts with extra indentation.

To Reproduce

  1. Go to your projects' config.yml and find one of the themes' ignore_files entry (or add it).

  2. Add extra spacing (tabs/spaces) before the dash "-".

It should now look something like this.

...
test-development:
  password: [password]
  theme_id: [id]
  store: [store-name].myshopify.com
  ignore_files:
    - config/settings_data.json
      - /locales/* # note the extra spaces before this line
  1. Make a change in any of your locale files

  2. Run theme deploy --env="test-development"

The change is now updated on the respective theme

Expected behavior I would expect this to either:

Environment (please complete the following information):

Additional context Has been tested on both M1 and Intel macs