Describe the bugconfig.yml does not respect ignore_files settings if the respective file or path starts with extra indentation.
To Reproduce
Go to your projects' config.yml and find one of the themes' ignore_files entry (or add it).
Add extra spacing (tabs/spaces) before the dash "-".
It should now look something like this.
...
test-development:
password: [password]
theme_id: [id]
store: [store-name].myshopify.com
ignore_files:
- config/settings_data.json
- /locales/* # note the extra spaces before this line
Make a change in any of your locale files
Run theme deploy --env="test-development"
The change is now updated on the respective theme
Expected behavior
I would expect this to either:
Just work, ignore the locales changes - it's explicitly defined in ignore_files
Throw an error and do nothing
Environment (please complete the following information):
OS [e.g. iOS]: Mac OS Monterey 12.1
Themekit version (run theme version to check): ThemeKit 1.3.0 darwin/amd64
Editor [e.g. atom, sublime]: VS Code
Ignore:
Additional context
Has been tested on both M1 and Intel macs
Describe the bug
config.yml
does not respectignore_files
settings if the respective file or path starts with extra indentation.To Reproduce
Go to your projects'
config.yml
and find one of the themes'ignore_files
entry (or add it).Add extra spacing (tabs/spaces) before the dash "-".
It should now look something like this.
Make a change in any of your locale files
Run
theme deploy --env="test-development"
The change is now updated on the respective theme
Expected behavior I would expect this to either:
ignore_files
Environment (please complete the following information):
Additional context Has been tested on both M1 and Intel macs