Shopify / themekit

Shopify theme development command line tool.
https://shopify.dev/tools/theme-kit
MIT License
1.17k stars 369 forks source link

Render could not be removed from theme by running the script. Internal Server Error with id - c651d43d-0b69-4212-9a38-cef70f14c044 #977

Closed svitlanatsymbal closed 1 year ago

svitlanatsymbal commented 1 year ago

Snippet render code is not removed from theme.liquid when Zipify OneClickUpsell app is disabled. Error from Shopify in logs: Failed to uninstall snippet: Internal Server Error If you report this error, please include this id: c651d43d-0b69-4212-9a38-cef70f14c044.

Steps to reproduce the behavior:

  1. have Zipify OneClickUpsell app installed on the store
  2. disable OneClickUpsell app
  3. go to theme to ensure that oneclickupsellapp-theme snippet and render code is removed from theme

Expected behavior oneclickupsellapp-theme snippet is removed from theme when Zipify OneClickUpsell app is disabled Snippet render code is removed from theme.liquid when Zipify OneClickUpsell app is disabled

Environment (please complete the following information):

Additional context Zipify OCU app run a script that parses theme.liquid file to add this code when app is enabled and remove this code when app is disabled. Here is the code: {% render 'oneclickupsellapp-theme', oneclickupsellapp: oneclickupsellapp %} {% assign oneclickupsellapp = true %}

In the last 1h this functionality stopped to work. All our customers are not able to enable or disable our app. As we see Zipify OCU snippet file is removed but render is not. Also, our parsing script could not add this code to theme.liquid when app is enabled.

Screenshot 2022-07-20 at 18 13 26 Screenshot 2022-07-20 at 18 19 34
svitlanatsymbal commented 1 year ago

Today the issue is not reproduced any more, it could be closed.