Shopify / tslint-config-shopify

Shopify’s TypeScript rules and configs.
https://www.npmjs.com/package/tslint-config-shopify
37 stars 3 forks source link

Missing no-unused-variable #19

Closed lemonmade closed 7 years ago

lemonmade commented 7 years ago

https://palantir.github.io/tslint/rules/no-unused-variable/ doesn't seem to be part of the config. Are we sure we have all the rules configured?

cc/ @GoodForOneFare @ismail-syed

ismail-syed commented 7 years ago

I'm pretty sure it's been deprecated

I remember the initial run with tslint it was shouting about some rule being deprecated. I believe it's this one. They probably just didn't update their website docs.

lemonmade commented 7 years ago

Welp, OK. I guess we need to turn on those flags for TS then.