Created a custom rule for import-type-order

Shopify / tslint-config-shopify

Shopify’s TypeScript rules and configs.

https://www.npmjs.com/package/tslint-config-shopify

37 stars 3 forks source link

Created a custom rule for import-type-order #48

Closed ismail-syed closed 7 years ago

ismail-syed commented 7 years ago

Enforce a certain structure in your imports. Import structure should be listed in the following order:

Module imports
Absolute imports
Relative parent/ancestor directory imports
Relative sibling directory imports

Issue https://github.com/Shopify/tslint-config-shopify/issues/42

ismail-syed commented 7 years ago

@GoodForOneFare All the changes are addressed. Have another look and let me know what you think.

I've created an issue for creating custom Rule fixes. I'll add those as separate PR's in the near future, so we can keep things moving with this PR.

GoodForOneFare commented 7 years ago

A CHANGELOG update would be nice, too.

ismail-syed commented 7 years ago

@GoodForOneFare I think we're good now! 🤞

ismail-syed commented 7 years ago

Ewww. Thought I'd give the GitHub web ui a shot for fixing merge conflicts. It left a merge commit Merge branch 'master' into custom-rule_structured-imports. Pretty convenient though.