Initial tslint rules - Githubissues

Shopify / tslint-config-shopify

Shopify’s TypeScript rules and configs.

https://www.npmjs.com/package/tslint-config-shopify

37 stars 3 forks source link

Initial tslint rules #5

Closed ismail-syed closed 7 years ago

ismail-syed commented 7 years ago

Hello friends :)

Looking for feedback on our new TypeScript linter rules. Specifically the comments with <FEEDBACK> tagged at the end of the comment.

At this time, if you wanna give this linter a test:

Clone the repo locally
Checkout to the intialize branch
Add some TypeScript files to the root directory
Run yarn run tslint

All feedback is welcome. giphy 5

/cc @Shopify/javascript

bouk commented 7 years ago

What are we using Typescript for?

lemonmade commented 7 years ago

We're trying out TypeScript for a possible reworking of the admin. Not 100% sold yet on the TypeScript v Flow thing, but I'd like us to have linters for both so we can compare them on the tooling side.