search

Shopify / tslint-config-shopify

Shopify’s TypeScript rules and configs.
https://www.npmjs.com/package/tslint-config-shopify
37 stars 3 forks source link

Restore allowing leading underscore in variable names #80

Closed kaelig closed 7 years ago

kaelig commented 7 years ago

Allows authors to add a leading underscore to unused arguments of a function (e.g. when the function signature is dictated by a third party API).

e.g.

  private handleOnBeforeChange(_editor, _data, value) {
    this.setState({value});
  }
ismail-syed commented 7 years ago

Can you update the changelog too, please? We can 🚢 a 3.0.2 release too.

kaelig commented 7 years ago

Changelog updated!

GoodForOneFare commented 7 years ago

Nice one. I always forgot to change this after working around it 😅