Open timvandam opened 4 months ago
@shopify/retail-ui-extensions-react @ 1.5.1
The issue is twofold:
onEndReached
It should call onEndReached when the end is reached, and it should support the number of rows decreasing
This video shows both issues
https://github.com/Shopify/ui-extensions/assets/35376389/062b16ec-1a30-4bbe-b354-2d31294637ca
The only workaround I have found is to set key on List, but this makes it flicker :/
key
Another work around is to ensure that data becomes an empty array. This seems to reset something internally that causes it to continuously call onEndReached again
data
Please list the package(s) involved in the issue, and include the version you are using
@shopify/retail-ui-extensions-react @ 1.5.1
Describe the bug
The issue is twofold:
component is calling the
onEndReached
prop before reaching the end of the list.Steps to reproduce the behavior:
Expected behavior
It should call onEndReached when the end is reached, and it should support the number of rows decreasing
Screenshots
This video shows both issues
https://github.com/Shopify/ui-extensions/assets/35376389/062b16ec-1a30-4bbe-b354-2d31294637ca
Additional context
The only workaround I have found is to set
key
on List, but this makes it flicker :/