Closed merkoyep closed 4 months ago
We detected some changes in packages/*/package.json
or packages/*/src
, and there are no updates in the .changeset
directory. If the changes are user-facing and should cause a version bump, run yarn changeset
to track your changes and include them in the next release CHANGELOG. If you are making simple updates to repo configuration, examples, or documentation, you do not need to add a changeset.
This looks great. I wonder if we could reuse the examples from the product search API docs as examples for how to use the List. Since it shows how to render the list with several of the properties
Background
BadgeProps
,SubtitleType
, andBadge(s)
.https://github.com/Shopify/ui-extensions/assets/81783308/8946d23a-a11f-4635-afcd-4e72f3037b5c
Solution
Edited
List.ts
andBadge.ts
to add descriptions to referenced Props.Added subsections with generic sections to the page for Guidelines and ContentGuidelines sections.
🎩
Visit THIS SPINSTANCE
Compare it with the old docs.
Read through the List component docs, ensuring you click through the sub-props that are commonly nested within the main props like
data
.Take note of formatting and layout.
Anything else that is expected for component docs.
Checklist