Shopify / ui-extensions

MIT License
248 stars 35 forks source link

update page examples #2081

Closed sylvhama closed 2 weeks ago

sylvhama commented 2 weeks ago

Background

Part of https://github.com/Shopify/core-issues/issues/72042

The Page examples are using the wrong prop.

Solution

I updated the example to use accessibilityLabel instead of children.

🎩

https://shopify-dev.customer-account-web-shopify-dev-u5w6.sylvain-hamann.us.spin.dev/docs/api/customer-account-ui-extensions/unstable/components/page

Checklist

github-actions[bot] commented 2 weeks ago

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset directory. If the changes are user-facing and should cause a version bump, run yarn changeset to track your changes and include them in the next release CHANGELOG. If you are making simple updates to repo configuration, examples, or documentation, you do not need to add a changeset.

sylvhama commented 2 weeks ago

Looking good, but it still feels a bit weird that primaryAction uses the children, but secondaryAction does not. Isn't it worth to align them both? 🤔

We could do that in the future, for now I want to fix the doc to have a working example. It's a quick win.