Shopify / ui-extensions

MIT License
268 stars 36 forks source link

Regression: Modal has unnecessary bottom padding #2365

Closed patryk-smc closed 1 month ago

patryk-smc commented 1 month ago

Please list the package(s) involved in the issue, and include the version you are using

"@shopify/ui-extensions": "2024.7.0",
"@shopify/ui-extensions-react": "2024.7.0",

Describe the bug

In last days, our modals started getting unnecessary bottom padding

Steps to reproduce the behavior:

            <Link
              overlay={
                <Modal id="my-modal" title="Return policy">
                  <TextBlock>
                    We have a 30-day return policy, which means you have 30 days after receiving
                    your item to request a return.
                  </TextBlock>
                  <TextBlock>
                    To be eligible for a return, your item must be in the same condition that you
                    received it, unworn or unused, with tags, and in its original packaging. You’ll
                    also need the receipt or proof of purchase.
                  </TextBlock>
                </Modal>
              }
            >
              Return policy
            </Link>

Expected behavior

No bottom padding should exist in modal

Screenshots

Image

Additional context

Side note: modal title and "X" button also got padding in last month or so, not sure if this was intended or not, but I'm not a fan of this, it looks bit off when modal has no padding

patryk-smc commented 1 month ago

@oliverigor Here you go :)

jeanffc commented 1 month ago

We are experiencing the same issue.

oliverigor commented 1 month ago

@patryk-smc @jeanffc, should be fixed now.

patryk-smc commented 1 month ago

Indeed it is, thank you so much for quick turnaround @oliverigor !!

Since you're at it, I also filed #2377 which might be related to Modal as well. Would appreciate you taking a look. Thanks again!