search

Shopify / ui-extensions

MIT License
267 stars 35 forks source link

customer account ui: Modal with no actions are showing separator line #2437

Open mateusvahl opened 2 days ago

mateusvahl commented 2 days ago

Please list the package(s) involved in the issue, and include the version you are using

"@shopify/ui-extensions": "2024.10.x",
"@shopify/ui-extensions-react": "2024.10.x",

Describe the bug

Noticed recently that modals now have primaryAction and secondaryAction props(great!), however, if the modal is not using those properties the separator line is still showing:

Image

This makes our current modals that are not using primaryAction and secondaryAction a bit odd:

Image

Expected behavior

Not show separator line when no actions are provided.

mateusvahl commented 2 days ago

We'll be moving our modals to use primary/secondary props, but still wondering if the line should shown when no actions are provided.