search

Shopify / ui-extensions

MIT License
260 stars 36 forks source link

Post purchase <View/> component border not working anymore #259

Open mirceapiturca opened 2 years ago

mirceapiturca commented 2 years ago

Please list the package(s) involved in the issue, and include the version you are using

Describe the bug

<View border="base" padding="base"> as per your example at https://github.com/Shopify/ui-extensions/blob/main/packages/post-purchase-ui-extensions-react/src/components/View/examples/basic-view.example.tsx#L7 padding and a border should be added around the <View/> element.

The <View/> component displayed a border and padding when the border and padding attributes were present.

Steps to reproduce the behavior:

  1. Add the following component to a post-purchase checkout extension: <View border="base" padding="base"></View>

Expected behavior

A border and padding around the element.

Screenshots

Additional context

jash-patel2000 commented 2 years ago

@mirceapiturca, it's the right same bug for me.

mirceapiturca commented 2 years ago

@jash-patel2000 Thanks for confirming this. Let's hope we get some clarity if the <View> component has or not a border option (and what are the alternatives, if any).

dani-sanomads commented 1 year ago

@mirceapiturca Any updates? Are they updating anything for the post purchase components?

mirceapiturca commented 1 year ago

@dani-sanomads Hopefully Shopify will update the post-checkout components to match the Checkout UI components. It looks to me like something went wrong here and it is hard to make right.

dani-sanomads commented 1 year ago

@mirceapiturca . Yes, It would be great if they could update it just like the checkout extension components.

gil-- commented 1 year ago

I think post purchase is currently in maintenance mode (no updates / fixes) but they mentioned on a Discord AMA that they would get post purchase aligned with checkout extension in the future. Maybe next year (2024)?

chienit3bk commented 10 months ago

I have the same bug