search

Shopify / vscode-shopify-ruby

An opinionated and auto-configured set of extensions for Ruby development
MIT License
176 stars 13 forks source link

Message about uninstalling reborn.ruby and wingrunr21.vscode-ruby upon Vscode startup #431

Closed obromios closed 1 year ago

obromios commented 1 year ago

Operating System

OSX 13.3.1

Ruby version

3.1.3

Project has a bundle

Ruby version manager being used

rvm

Description

Looking in the .ruby-lsp Gemfile.lock, I am using ruby-lsp 0.4.5 and the extension version is 0.2.5 and Vscode says it is up to date. When I start Vscode I see the following message

The Ruby LSP has fully replaced the Ruby plugin functionality. Uninstall therebornix.rubyand thewingrunr21.vscode-rubyextensions. ClickCleanupto remove related configuration.

I have searched for the two cited extensions and can find neither. I have clicked 'Cleanup` but the error occurs again upon startup. I am new to the extension but I am finding very useful, thank you. It is just a bit talkative upon startup.

andyw8 commented 1 year ago

I've transferred this issue to https://github.com/Shopify/vscode-shopify-ruby since the message originates there:

https://github.com/Shopify/vscode-shopify-ruby/blob/eb2ca492b4379a8e42a033d4df406eb7827384da/src/extension.ts#L9

rebornix.ruby may be listed in the VS Code extension panel as just 'Ruby' – are you sure you don't have that still?

vinistock commented 1 year ago

We basically use VS Code's API to check if any of the two extensions are installed. Unless there's a bug in VS Code, you most definitely must have one of the two installed.

The reason we print the message is because using both extensions at once may result in some duplicate functionality or conflicts.

Cleanup just removes any Rebornix.Ruby related configurations from your user settings. It does not uninstall the extension for you.

obromios commented 1 year ago

I have typed just 'ruby' into the extension panel, and I have

  1. Ruby by Peng Li
  2. Ruby by Shopify (which I assume is you guys)
  3. VS code ruby

Are 1. or 3. rebornix ruby? Should I uninstall them anyway given I am using Shopify ruby?

If it is not 1. and 3., what strings does the api use to search for these two extensions?

andyw8 commented 1 year ago

1 is rebornix ruby, you can see from the URL here: https://marketplace.visualstudio.com/items?itemName=rebornix.Ruby

You should remove 3 as well.

obromios commented 1 year ago

That worked thank you.