Shopify / vscode-shopify-ruby

An opinionated and auto-configured set of extensions for Ruby development
MIT License
176 stars 13 forks source link

add support for standardrb #551

Closed alec-c4 closed 11 months ago

alec-c4 commented 11 months ago

Hey, please add support for standardrb. Currently I cannot disable integrated formatter

SCR-20231018-lnyh SCR-20231018-logz
vinistock commented 11 months ago

Work has already begun in Standard to use a Ruby LSP addon, so that we can format using Standard (see this).

For the time being, you can simply reject this setting so that the extension won't configure it. Use the commands to clear the cache and re-trigger the initial configuration dialogue. Then pick Decide for each and reject the formatter setting.

We'll not be adding any specialized configuration for standard in this extension.

alec-c4 commented 11 months ago

@vinistock Hey, settings reject isn't helped :(

vinistock commented 11 months ago

Can you explain what happened and which steps you took? Did you clear the cache first?

alec-c4 commented 11 months ago

@vinistock sure! 1 - cleared cache 2 - restarted vscode 3 - declined every option on start 4 - problem still exists :(

vinistock commented 11 months ago

Can you please try to

Let me know if that does the trick.

alec-c4 commented 11 months ago

Nothing changed :( finally my config looks like

{
  // Editor
  "editor.accessibilitySupport": "off",
  "editor.cursorBlinking": "expand",
  // "editor.defaultFormatter": "esbenp.prettier-vscode",
  "editor.formatOnSave": true,
  "editor.formatOnType": true,
  "editor.minimap.enabled": false,
  "editor.tabSize": 2,
  "editor.unicodeHighlight.ambiguousCharacters": true,

  // Extensions
  "extensions.ignoreRecommendations": true,

  // Emmet
  "emmet.triggerExpansionOnTab": true,
  "emmet.includeLanguages": {
    "phoenix-heex": "html",
    "astro": "html",
    "svelte": "sveltehtml"
  },

  // Files
  "files.associations": {
    "*.erb": "erb",
    "*.html.erb": "erb",
    "*.yml": "yaml"
  },
  "files.autoSave": "onFocusChange",
  "files.defaultLanguage": "plaintext",
  "files.insertFinalNewline": true,

  // Security
  "security.workspace.trust.banner": "never",
  "security.workspace.trust.enabled": false,

  // Workbench
  "workbench.colorTheme": "Spinel",
  "workbench.iconTheme": "vscode-great-icons",
  "workbench.startupEditor": "none",

  // Terminal
  "terminal.integrated.fontFamily": "MesloLGS NF",
  "terminal.integrated.scrollback": 99999999999,
  "terminal.integrated.env.osx": {
    "FIG_NEW_SESSION": "1"
  },
  "terminal.external.osxExec": "iTerm.app",

  // Erb
  "[erb]": {
    "editor.defaultFormatter": "aliariff.vscode-erb-beautify"
  },

  // Plugins - Tailwind
  "tailwindCSS.emmetCompletions": true,

  // Plugins - eslint
  "eslint.validate": [
    "javascript",
    "javascriptreact",
    "astro", // Enable .astro
    "typescript", // Enable .ts
    "typescriptreact" // Enable .tsx
  ],

  // Plugins - Svelte
  "[svelte]": {
    "editor.defaultFormatter": "svelte.svelte-vscode"
  },
  "svelte.enable-ts-plugin": true,

  // Plugins - Erb formatter
  "vscode-erb-beautify.keepBlankLines": 1,
  "git.enableSmartCommit": true,
  "git.autofetch": true,

  // Dart settings
  "[dart]": {
    "editor.rulers": [80],
    "editor.selectionHighlight": false,
    "editor.suggestSelection": "first",
    "editor.tabCompletion": "onlySnippets",
    "editor.wordBasedSuggestions": false
  },
  "dart.openDevTools": "flutter",
  "[xml]": {
    "editor.defaultFormatter": "redhat.vscode-xml"
  },

  "githubPullRequests.pullBranch": "never",
  "[ruby]": {
    "editor.defaultFormatter": "Shopify.ruby-lsp",
    "editor.formatOnSave": true,
    "editor.formatOnType": true,
    "editor.tabSize": 2,
    "editor.insertSpaces": true,
    "files.trimTrailingWhitespace": true,
    "files.insertFinalNewline": true,
    "files.trimFinalNewlines": true,
    "editor.rulers": [
      120
    ],
    "editor.semanticHighlighting.enabled": true
  }
}