search

Shopify / vscode-shopify-ruby

An opinionated and auto-configured set of extensions for Ruby development
MIT License
176 stars 13 forks source link

Syntax highlighting breaks on non-Spinel themes #578

Closed noahgregory-basis closed 8 months ago

noahgregory-basis commented 8 months ago

After reading #562, I was a bit concerned about using these extensions for general development, but they appear fine to use right now. I've just noticed, though, syntax highlighting sometimes breaks in other color themes. Below is a Regexp to match a Japanese date format in the built-in Red color theme. It does not appear like this without the Ruby extensions installed. To note, the Spinel themes that comes with the extensions do not appear to have this issue.

Screenshot 2024-02-01 at 17 10 12
vinistock commented 8 months ago

I was a bit concerned about using these extensions for general development, but they appear fine to use right now

They are all for general development.

though, syntax highlighting sometimes breaks in other color themes.

It's not related to themes, it's actually a bug with handling multibyte characters: https://github.com/Shopify/ruby-lsp/issues/1162. You can see that the highlighting is offset by a few characters, which is the number of extra bytes in the Japanese characters.

I'll close this issue to keep discussions centralized in that one.