search

Shopify / vscode-shopify-ruby

An opinionated and auto-configured set of extensions for Ruby development
MIT License
176 stars 13 forks source link

Update Readme with instruction to add Rubocop in Gemfile #595

Closed bibstha closed 6 months ago

bibstha commented 6 months ago

Related comment https://github.com/Shopify/vscode-shopify-ruby/issues/443#issuecomment-1567160768

The Ruby LSP doesn't support running RuboCop from a global installation. It must be a part of your Gemfile or else it just gets ignored.

bibstha commented 6 months ago

"I have signed the CLA!"

vinistock commented 6 months ago

Thank you for the PR. I agree with adding documentation mentioning that the formatter gem must be a part of the bundle.

However, this is not the correct repository for this documentation. As mentioned in the README, this is an extension pack that just includes other extensions and doesn't implement any features.

The right place to document this is in the Ruby LSP's documentation, in the configuring formatters section.