search

Shopify / vscode-shopify-ruby

An opinionated and auto-configured set of extensions for Ruby development
MIT License
176 stars 13 forks source link

Remove setting recommendation engine #616

Closed vinistock closed 2 months ago

vinistock commented 3 months ago

Once https://github.com/Shopify/ruby-lsp/pull/1958 is shipped, there's no longer a reason to be heavy handed with our recommendations. We can just rely on the contributed defaults and no longer offer to mutate the user's settings.

This PR removes all of the infrastructure we had for verifying, overriding and caching settings.

Question

For the Spinel theme, I still kept the mechanism to offer that. It feels a bit much to contribute the theme as a configuration default. Thoughts?

andyw8 commented 2 months ago

For the Spinel theme, I still kept the mechanism to offer that. It feels a bit much to contribute the theme as a configuration default. Thoughts?

Agreed.

andyw8 commented 2 months ago

If the theme is useful for Ruby devs in general, should the theme suggestion logic be on Ruby LSP too?

Even if we don't do that, it might be good to mention it more prominently in the Ruby LSP README.

vinistock commented 2 months ago

If the theme is useful for Ruby devs in general, should the theme suggestion logic be on Ruby LSP too?

That would involve moving the theme there as well since you can install the Ruby LSP without the extension pack. I see that as the future, but it might be a bit early for that.