@shopify/eslint-plugin: Add support for ESLint v9 and flat config - Githubissues

Shopify / web-configs

Common configurations for building web apps at Shopify

MIT License

461 stars 55 forks source link

@shopify/eslint-plugin: Add support for ESLint v9 and flat config #425

Open EvgenyOrekhov opened 4 weeks ago

EvgenyOrekhov commented 4 weeks ago

Overview

ESLint v9 was released 2 months ago: https://eslint.org/blog/2024/04/eslint-v9.0.0-released/

Type

[ ] New feature
[x] Changes to existing features

Motivation

What inspired this feature request? What problems were you facing, or what else makes you think this should be included?

Impossible to use @shopify/eslint-plugin with ESLint v9

Labels

[ ] Add the Type: Feature Request label to this issue.

Area

[ ] Add any relevant Area: <area> labels to this issue

Scope

Is this issue related to a specific package?
- [ ] Tag it with the Package: <package_name> label.
Is it related to a new package?
- [ ] Tag it with the New package Label

Checklist

[ ] Please delete the labels section before submitting your issue
[ ] I have described this issue in a way that is actionable (if possible)

andyw8 commented 3 days ago

This is important to address, as there is the danger that updating to ESLint v9 can result in checks being silently skipped:

https://github.com/Shopify/vscode-shopify-metrics/pull/614