search

Shopify / yjit-bench

Set of benchmarks for the YJIT CRuby JIT compiler and other Ruby implementations.
MIT License
87 stars 22 forks source link

Don't print individual run timings #301

Closed casperisfine closed 4 months ago

casperisfine commented 4 months ago

It's a lot of output you don't need most of the time but more importantly, when running the script from a TTY it can be relatively slow.

k0kubun commented 4 months ago

I rely on the output to keep track of the progress. If you think it's a lot of output, it implies that a single iteration should do more work. When a single iteration runs as long as railsbench or lobsters, it outputs only 25 lines, which should be fine and not slow.

casperisfine commented 4 months ago

Hum, what about printing a single . for each iteration?

maximecb commented 4 months ago

IMO the current approach is pretty good. Hasn't been a problem?

maximecb commented 4 months ago

But we could add a --quieter option for Jean. Will accept that PR ;)

k0kubun commented 4 months ago

Hum, what about printing a single . for each iteration?

Not just the progress but I want to see the timings as well. If you only show .s, it would hide the distribution of timings, which seems like useful information to me. When there's a spike in a few iterations, it implies major GCs, for example.