Shopify / yjit-bench

Set of benchmarks for the YJIT CRuby JIT compiler and other Ruby implementations.
MIT License
87 stars 22 forks source link

Fix a leak in Lobsters benchmark #322

Closed casperisfine closed 2 months ago

casperisfine commented 2 months ago

Profiling the lobsters benchmark I'm seeing a fairly large time spent joining tags in TaggedLogger.

That intruigued me, and by digging I noticed the requests UUIDs kept being appended but never removed.

So for every single request we have one more tag, this is skewing the benchmark a bit, as we spend much more time than we should in logging.

Capture d’écran 2024-09-06 à 17 49 33
casperisfine commented 2 months ago

After:

Capture d’écran 2024-09-06 à 17 53 40