Shopify / yjit-metrics

"Tasks for benchmarking, building and collecting stats for YJIT"
MIT License
14 stars 9 forks source link

Graph YJIT & CRuby total memory usage over time #210

Closed maximecb closed 1 year ago

maximecb commented 1 year ago

We've been doing a lot of work to improve YJIT's memory overhead, with most of the credit going to @k0kubun and @XrXr. I think it would be interesting and useful if we could have a graph on the speed.yjit.org front page that plotted YJIT and the CRuby interpreter's total memory usage over time, say on railsbench and maybe also liquid or activerecord.

It might actually be better to have only railsbench visible, with two separate curves on the graph, and total memory usage in MiB. The reason we want two separate curves and not just a percentage over the interpreter is that the benchmark may change over time, and the interpreter's implementation may change too. Having two separate curves would make it obvious if YJIT and CRuby's memory usage increase in lockstep (not our fault) or if only YJIT's memory usage changes.

@noahgibbs if I'm not mistaken you've already been gathering memory usage data on the benchmarks, so most of the work would be in generating the graph and including it on the front page of speed.yjit.org ?

noahgibbs commented 1 year ago

Yup, we're gathering RSS data. So yeah, we have the data, shouldn't be all that difficult to add the graphs. I'll get on that.

maximecb commented 1 year ago

Wonderful! :)

noahgibbs commented 1 year ago

Done. Added a link on the front page.