search

Shopify / yjit-metrics

"Tasks for benchmarking, building and collecting stats for YJIT"
MIT License
14 stars 9 forks source link

ARM-only reports aren't working #216

Closed noahgibbs closed 6 months ago

noahgibbs commented 1 year ago

It's entirely possible to get ARM data but no x86 data for a given timestamp -- for instance, CRuby might have an x86-specific crash, or there might be a rare crash that triggers by chance on x86 but not ARM. These things happen.

Right now, those timestamps get skipped. No ARM data shows up speed.yjit.org. That's an intentional thing, because the reporting code was all written x86-only initially, and some of it has bugs when trying to report with no x86 data present.

But it's not conceptually complicated. It just needs somebody to go through and fix the bugs with those reports.

rwstauner commented 6 months ago

ARM only reports work locally now: https://github.com/Shopify/yjit-metrics/pull/243/commits/268a7f72f20d3b6aca24cde3d6f1f5956d3de143

It sounds like we could remove the flag and let this behavior always be the case.

maximecb commented 6 months ago

It sounds like we could remove the flag and let this behavior always be the case.

If it makes things simpler, sure 👍 :)