search

Shopify / yjit-metrics

"Tasks for benchmarking, building and collecting stats for YJIT"
MIT License
14 stars 9 forks source link

Remove noah's github token from test data files #232

Closed rwstauner closed 8 months ago

rwstauner commented 8 months ago

This env var was renamed to BENCHMARK_CI_GITHUB_TOKEN in e1fcd564c23469fd0c05da9b9fa967afcdb119fc and subsequently removed in 44f895bc03f0af32324187aeaefb473c6dd68073.

If we remove the remnants of it from the repo then we won't have someone else find it and wonder if there is still action needed to rotate it.

The only remaining references are reading it (we don't currently set it anywhere) and currently that remaining usage has been turned off: https://github.com/Shopify/yjit-metrics/blob/1aa73367825042271f03d243b5fbea455b2220b0/continuous_reporting/benchmark_and_update.rb#L115-L118 https://github.com/Shopify/yjit-metrics/blob/1aa73367825042271f03d243b5fbea455b2220b0/continuous_reporting/gh_tasks/run_benchmarks.sh#L9