search

Shopify / yjit-metrics

"Tasks for benchmarking, building and collecting stats for YJIT"
MIT License
14 stars 9 forks source link

Add new timeline page that graphs all rubies for selected benchmarks #301

Closed rwstauner closed 3 months ago

rwstauner commented 3 months ago

This adds another button to the bottom of the home page that links to a new timeline view that shows the benchmark speed for each of the current ruby configs:

image

I'd like to make it prettier and more responsive, but it's consistent with the other timelines we currently have (this will be the 4th).

If we want to do more improvements we could probably merge them all into one timeline page with some configuration elements to pick the type of metric and which ruby configs to display, but that will require a larger rewrite.

closes #220

rwstauner commented 3 months ago

Sorry, I cut off the legend, but it's the same as all the other timelines

k0kubun commented 3 months ago

I couldn't find this page on https://speed.yjit.org/ now. How do you reach this page?

rwstauner commented 3 months ago

The next time the benchmarks run the new pages would be generated.

I manually went to the server and pulled and ran continuous_reporting/gh_tasks/report_and_upload.sh so you can see it now.

k0kubun commented 3 months ago

Thanks, I can see that now. Is it intentional that you can't see the revision when you hover a data point in these "Over Time" pages ("YJIT Stats Over Time", "Benchmark Results Over Time"), or is my browser not working correctly?

rwstauner commented 3 months ago

Good catch. Looks like there is some css I didn't properly duplicate. I'll push another PR

rwstauner commented 3 months ago

Fix for missing tooltips: https://github.com/Shopify/yjit-metrics/pull/302

rwstauner commented 3 months ago

I regenerated again and the tooltips are back