Shopify / yjit-metrics

"Tasks for benchmarking, building and collecting stats for YJIT"
MIT License
14 stars 9 forks source link

Add annotations to timeline graphs for noteworthy events #361

Closed rwstauner closed 4 days ago

rwstauner commented 4 days ago

refs #271

This creates the appearance of dashed lines to annotate noteworthy events. It uses a masked rectangle instead of a line with a stroke-dash-array because when you hover the element to see the tooltip the hover goes back to the parent element in between the dashes which can be quite frustrating.

This should help avoid confusion by providing explanations for changes in graphs.

The current list of events is managed manually (useful for things like server upgrades). It was previously kept as a json file but as far as I can tell it was never used.

In the future we could automatically add events based on commit logs in yjit-bench as described in #271.

image