search

ShoppinPal / ng-mobile-menu

An AngularJS module that provides a slide out menu for your application.
MIT License
100 stars 25 forks source link

sp-page could be class rather than id #7

Open sfletche opened 10 years ago

sfletche commented 10 years ago

Sorry for not going the more appropriate forking process...but here's my unsolicited suggestion nonetheless.

I've found it more useful to define sp-page as a class on my DOM elements rather than limit it to an id (allowing only 1 element to be defined with that distinction). And this solution appears to be as simple as changing the sp-page references in your css from id indicators (#) to class indicators (.).

Now I have multiple 'pages' (divs / partial templates) that can utilize the same sliding mobile menu.

Morriz commented 10 years ago

+1...nice plugin btw, just what I needed. I suggest not ever to use ids, since it always prevents multiple instances to run side by side. I am going to adapt it to allow multiple menu's by using class selectors like sfletche suggested. Will make pull request when ready...

Morriz commented 10 years ago

any comments on this? will I be encountering difficulties you can think of now?

pulkitsinghal commented 10 years ago

@Morriz - This plugin was written by a colleague and while its great, I would also recommend that you take a peek and switch over to ionic as they have support for a side-menu as well.

Morriz commented 10 years ago

Tnx, but I know ionic and tested it. I am not looking for a full stack mobile framework. Actually more the other way around: Desktop First.

On 5 feb. 2014, at 22:40, pulkitsinghal notifications@github.com wrote:

@Morriz - This plugin was written by a colleague and while its great, I would also recommend that you take a peek and switch over to ionic as they have support for a side-menu as well.

— Reply to this email directly or view it on GitHub.