search

ShoreShop / ShoreModel_Benchmark

This repository is set to benchmark the shoreline models contributed to the ShoreShop2.0
14 stars 9 forks source link

Data load wrapper #2

Open simmonsja opened 1 month ago

simmonsja commented 1 month ago

Hi @yongjingmao, Thanks a lot for putting this together and looking forward to seeing some of the models produced. I had a quick play around this afternoon and created a small function to load the data in a line and an example of aligning to waves - its not perfect or general (and people should check before using lest it ruin their modelling 😅). Perhaps something similar/tested (condensing 1.data_explore) in the main repo could save others some time, particularly the data-driven modellers!

https://github.com/simmonsja/ShoreModel_Benchmark/blob/jsdev/3.modelling_template.ipynb (with functions in functions/data_load.py)

One minor thing while putting that together was seeing that the dates weren't playing ball always - the shorelines_*.csv files were a bit inconsistent with the date format - perhaps it would be worth just rounding all to %Y-%m-%d to make it easier rather than having additional H:M:S?

Thanks again!

yongjingmao commented 1 month ago

Hi @simmonsja , Great work for the data_loader. Definitely a handy tool for data-driven modelers. Thanks for sharing it. Good suggestion for rounding datetime of shoreline data. I have implemented it.